Skip to content

feat(cdk-pipeline): add url and sns topic for manual approval in cdk pipeline (re-create PR since original is auto-closed) #34654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2025
Merged

feat(cdk-pipeline): add url and sns topic for manual approval in cdk pipeline (re-create PR since original is auto-closed) #34654

merged 4 commits into from
Jun 13, 2025

Conversation

@pitayapj
Copy link
Contributor

@pitayapj pitayapj commented Jun 9, 2025

Issue #32809

Closes #12273

Original PR with approved changes: #34227

Reason for this change

No concrete solution to output cdk diff in pipeline yet.
Include ExternalEntityLink and SNS Topic to manual approval step for custom diff check solution.

Description of changes

Add url for review and SNS topic in ManualApprovalStepProps

Description of how you validated changes

Unit tested

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 9, 2025 03:14
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 labels Jun 9, 2025
@pitayapj pitayapj changed the title feat(cdk-pipeline): add url and sns topic for manual approval in cdk pipeline (re-create PR since auto-closed) feat(cdk-pipeline): add url and sns topic for manual approval in cdk pipeline (re-create PR since original is auto-closed) Jun 9, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 9, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 9, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 9, 2025
@pitayapj
Copy link
Contributor Author

pitayapj commented Jun 9, 2025 •
edited
Loading

Exemption Request: request no integration test since no change made in the original ManualApprovalAction module.
Pipeline's manual action is only an extension of it

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 9, 2025
alvazjor
alvazjor previously approved these changes Jun 13, 2025
View reviewed changes
@alvazjor alvazjor added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 13, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 13, 2025 12:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@alvazjor alvazjor removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jun 13, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot dismissed alvazjor’s stale review June 13, 2025 13:37

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Jun 13, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 183acfc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 39f1636 into aws:main Jun 13, 2025
10 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alvazjor alvazjor alvazjor approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@alvazjor alvazjor

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(pipelines): view cdk diff output in CodePipeline

3 participants

@pitayapj @aws-cdk-automation @alvazjor